help me...!! it so close to complete....but i can't solve it

[fazreen]

aim :
-when push button1, the data 'a' will transmit and receive and the led will lighting,lcd will display switch on bed1 .

- when push button 2,the data 'b' will transmit and receive and led will lighting, lcd will display switch on bed2.

-if button 1 and 2 are not switch on...it will receive data 'c' that led will switch off and lcd will display switch off bed.

problem :

- they not receive the data...
-sometime data 'a' and 'b' receive but data 'c' not reiceve...
-overall,this program are very close to complete but i can solve complete it because of have a small problem that i can't solve.

( only use 2 button, lcd , and only one led )





#include <18F4550.h> // PIC18F4550 HEADER FILE

#fuses PUT, HS, NOWDT, NOLVP, NOBROWNOUT, // EXTERNAL CLOCK, NO WATCH DOG TIMER, NO LOW VOLTAGE PROGRAMMING

#use delay (clock=20M)
#use rs232(baud=9600, xmit=PIN_C6, rcv=PIN_C7, bits=8, parity=N, errors ) // 4 MHZ CRYSTAL
#include <lcd.c>


#define LED1 PIN_B6 // LED 1
//#define LED2 PIN_B7 // LED 2

#define BUTTON1 PIN_B0 // button1
#define BUTTON2 PIN_B1 // BUTTON2

#define LCD_E PIN_D0 // PIN E
#define LCD_RS PIN_D1 // PIN RS
#define LCD_RW PIN_D2 // PIN RW
#define LCD_D4 PIN_D4 // PIN D4
#define LCD_D5 PIN_D5 // PIN D5
#define LCD_D6 PIN_D6 // PIN D6
#define LCD_D7 PIN_D7 // PIN D7

void main ()
{
char data;
set_tris_b(0x01); // SET ALL PORT 0-b3 AS INPUT b4-b7 OUTPUT
//set_tris_d(0xFF);
//set_tris_c(0x80); // SET ALL PORT d AS OUTPUT PORT(0b 0000 0000)

output_b(0x00);
output_d(0xff);

lcd_init();

while(true)
{

while(!input(BUTTON1))
{

putc('a');


while(!input(BUTTON2))
{

putc('b');


while((input(BUTTON1))||(input(BUTTON2)))
{

putc('c');


data = getc();
switch(data)
{

case 'a' :output_high(PIN_B6);
printf(lcd_putc,"\fSWITCH ON BED1");
delay_ms (300);
break;

case 'b' :output_high(PIN_B6);
printf(lcd_putc,"\fSWITCH ON BED2");
delay_ms (300);
break;

case 'c' :output_low(PIN_B6);
printf(lcd_putc,"\fSWITCH OFF BED");
delay_ms (300);
break;

break;
}
}


}
}
}
}

[Ttelmah]

1) Learn to use the code buttons.
2) Do you have a 20MHz crystal, or 4MHz. Serial won't work, till your clock setup is right. Currently you have the HS oscillator (which says greater than 4MHz clock), 20MHz selected (which says I am using a 20MHz crystal), yet comment '4MHz crystal'.....
3) LCD pin defines need to be _before_ lcd.c is loaded.
4) Your comments disagree almost everywhere with what you do. For instance:

[Mike Walne]

[fazreen]

[fazreen]

[Mike Walne]

This is all very much like the thread you ran a month ago.

After several posts, you suddenly declared it was all OK.

Now it's not, AND you just got round to telling us it's Proteus.

I'm out, 'til you get some results with REAL hardware.

Mike

PS You only NEED to build ONE board. Use a PC to communicate with it.