SWITCH, CASE and BREAK

[jjude]

[Wayne_]

Firstly, what is your question ?

Secondly you have an error.

case : 1 should be case 1:
note the colon is in the wrong place.

And lastly

[Ttelmah]

Much tidier.

It is also worth being aware of a 'limitation' of the CCS implementation.
If you have a 'default' statement, though good in programming practice terms, this forces the switch statements to be individually tested. If instead all states are implemented with no 'default', the compiler uses a jump table. So, for the 'example' of dealing with cases from 1 to 10:

[Petar_2010]

Hello,

I have a problem with my code with the switch sentence.
The code is compiled correctly but the micro doesn´t work.
I want to have a different modules with steady light or intermittent depending of the state of the buttons.
I can´t see where is my error.
I apologize for my bad english.
This is my code:

// LEDS CONTROL
// 29/10/2018
//////////////////////////////////////////////////////////////////////

#include <16F1828.h>

#fuses NOMCLR

#use delay(internal=8MHz)

#use FIXED_IO( A_outputs=PIN_A0,PIN_A1,PIN_A2,PIN_A3,PIN_A4,PIN_A5 )
#use FIXED_IO( B_outputs=PIN_B4,PIN_B5,PIN_B6,PIN_B7 )
#use STANDARD_IO(C)

// DEFINE INPUT BUTTONS
#define BUTTON_1 PIN_C0
#define BUTTON_2 PIN_C1
#define BUTTON_3 PIN_C2
#define BUTTON_4 PIN_C3
#define BUTTON_5 PIN_C4
// DEFINE OUTPUT LEDS
#define LED_GREEN PIN_A0
#define LED_AMBER PIN_A1
#define LED_RED PIN_A2
#define LED_WHITE PIN_A4
#define LED_BLUE PIN_A5

#use rs232(baud=9600,bits=8, parity=N,xmit=PIN_b5,rcv=PIN_b4)

// DEFINE FUNCTIONS
void steady_1();
void steady_2();
void steady_3();
void steady_4();
void steady_5();

void interm_1();
void interm_2();
void interm_3();
void interm_4();
void interm_5();


//====================================
//====================================

void main()
{
port_c_pullups(0xff);


int8 estados;
output_a(0x00);


while(true)
{

switch (estados)
{
case 1:
if(input(BUTTON_1)==0)
steady_1();
else
interm_1();

break;

case 2:
if(input(BUTTON_2)==0)
steady_2();
else
interm_2();

break;

case 3:
if(input(BUTTON_3)==0)
steady_3();
else
interm_3();

break;

case 4:
if(input(BUTTON_4)==0)
steady_4();
else
interm_4();

break;

case 5:
if(input(BUTTON_5)==0)
steady_5();
else
interm_5();

break;


default:
output_a(0x00);


} //switch
} //while principal



} //main





//-----------------------------
//FUNCTIONS
//---------
void steady_1()
{
output_high(LED_GREEN);
}

void steady_2()
{
output_high(LED_AMBER);
}

void steady_3()
{
output_high(LED_RED);
}

void steady_4()
{
output_high(LED_WHITE);
}

void steady_5()
{
output_high(LED_BLUE);
}

//------------------------------
void interm_1()
{
output_high(LED_GREEN);
delay_ms(500);
output_low(LED_GREEN);
delay_ms(500);
}

void interm_2()
{
output_high(LED_AMBER);
delay_ms(500);
output_low(LED_AMBER);
delay_ms(500);
}

void interm_3()
{
output_high(LED_RED);
delay_ms(500);
output_low(LED_RED);
delay_ms(500);
}


void interm_4()
{
output_high(LED_WHITE);
delay_ms(500);
output_low(LED_WHITE);
delay_ms(500);
}

void interm_5()
{
output_high(LED_BLUE);
delay_ms(500);
output_low(LED_BLUE);
delay_ms(500);
}

//-------------------------------

[Ttelmah]

1) Learn to use the code buttons.

2)

[Petar_2010]

[Ttelmah]

Yes, just initilise the variable to the default state value, and when you see your button, increment is (and when it reaches '3' set it back to zero.

You show the code using five buttons, now you are only using one?.

Remember also that detecting a button, requires you to look for it changing, not just the act of it being on, and you need to cope with the probability that there will be bounce (a button won't cleanly go 'on').

[Petar_2010]

Thank you for your time Ttelmah,

Yes I need work with five buttons, but I think that is easier work with only one at first and then with five.
I found in that forum a very good example of use of two states of push button - (state up - button released) and (state down - button pressed).
Now I have two states of every of the five buttons, but I need a third state - intermittent.
This is the code:

[Ttelmah]

[Petar_2010]

Many, many thanks Ttelmah,

Very good job, but a little bit complicated. I need to learn more for can use your idea.
However, I´m very grateful.

[Ttelmah]

Evil grin....

However it is actually very simple.

A master 'tick'. Happens at about 10Hz.

This tests each button (using an array of button numbers). If the button is 'on'
increments a counter for that button. If off, clears the counter.
If the counter reaches '2', says 'on', and increments the operation state for that
button.
The state has three possibilities. OFF, FLASH, ON.
Then for each button, tests the state. If it is 'OFF' turns the LED off. If ON turns
the LED ON> IF it is in the 'FLASH' state, it turns it on if another counter being
run in the interrupt, is 10 to 20, or off if it is 0 to 9. So flashes the LED.
Now the events never delay, each test passes immediately to the next in
sequence, so the whole thing handles each button, and output in turn.

Problem with your existing code, is it only does one thing after another, and
so while it is flashing LED2 (say), it is not able to check any of the other
keys or flash any other LED.